Re: [PATCH net-next v3] ethernet: fix PTP_1588_CLOCK dependencies

From: Arnd Bergmann
Date: Thu Aug 05 2021 - 04:11:57 EST


On Wed, Aug 4, 2021 at 10:52 PM Keller, Jacob E
<jacob.e.keller@xxxxxxxxx> wrote:

> > diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
> > b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
> > index af84f72bf08e..4e18b64dceb9 100644
> > --- a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
> > +++ b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
> > @@ -6,6 +6,7 @@
> > config PCH_GBE
> > tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE"
> > depends on PCI && (X86_32 || COMPILE_TEST)
> > + depends on PTP_1588_CLOCK
> > select MII
> > select PTP_1588_CLOCK_PCH
> > select NET_PTP_CLASSIFY
>
> I did notice this one driver which now directly depends on PTP_1558_CLOCK, but I
> suspect that's because it actually doesn't work if you disable PTP?

Yes, it's the 'select PTP_1588_CLOCK_PCH' and 'select NET_PTP_CLASSIFY'
that actually need it.

Arnd