[tip: sched/core] sched/numa: Fix is_core_idle()

From: tip-bot2 for Mika Penttilä
Date: Thu Aug 05 2021 - 05:35:23 EST


The following commit has been merged into the sched/core branch of tip:

Commit-ID: 1c6829cfd3d5124b125e6df41158665aea413b35
Gitweb: https://git.kernel.org/tip/1c6829cfd3d5124b125e6df41158665aea413b35
Author: Mika Penttilä <mika.penttila@xxxxxxxxx>
AuthorDate: Thu, 22 Jul 2021 09:39:46 +03:00
Committer: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
CommitterDate: Wed, 04 Aug 2021 15:16:43 +02:00

sched/numa: Fix is_core_idle()

Use the loop variable instead of the function argument to test the
other SMT siblings for idle.

Fixes: ff7db0bf24db ("sched/numa: Prefer using an idle CPU as a migration target instead of comparing tasks")
Signed-off-by: Mika Penttilä <mika.penttila@xxxxxxxxx>
Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
Acked-by: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>
Acked-by: Pankaj Gupta <pankaj.gupta@xxxxxxxxx>
Link: https://lkml.kernel.org/r/20210722063946.28951-1-mika.penttila@xxxxxxxxx
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 11d2294..13c3fd4 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1486,7 +1486,7 @@ static inline bool is_core_idle(int cpu)
if (cpu == sibling)
continue;

- if (!idle_cpu(cpu))
+ if (!idle_cpu(sibling))
return false;
}
#endif