Re: [PATCH 1/2] usb: dwc2: rename DWC2_POWER_DOWN_PARAM_NONE state

From: Greg KH
Date: Thu Aug 05 2021 - 05:41:42 EST


On Thu, Aug 05, 2021 at 09:22:05AM +0000, Minas Harutyunyan wrote:
> Hi Greg,
>
> On 8/5/2021 1:15 PM, Greg KH wrote:
> > On Wed, Aug 04, 2021 at 01:44:20PM +0200, Marek Szyprowski wrote:
> >> DWC2_POWER_DOWN_PARAM_NONE really means that the driver still uses clock
> >> gating to save power when hardware is not used. Rename the state name to
> >> DWC2_POWER_DOWN_PARAM_CLOCK_GATING to match the driver behavior.
> >>
> >> Suggested-by: Minas Harutyunyan <Minas.Harutyunyan@xxxxxxxxxxxx>
> >> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> >> ---
> >> This is a follow-up of this discussion:
> >> https://urldefense.com/v3/__https://lore.kernel.org/linux-usb/26099de1-826f-42bf-0de7-759a47faf4a0@xxxxxxxxxxx/__;!!A4F2R9G_pg!LG012E4LzO4qVgWZHu_3eTbZ5zmdI4qENHbOuuLwm-IlhHF9KKIaYyJNaY2vXeg$
> >>
> >> This should be applied on top of v5.14-rc3.
> >
> > What else would I apply it on top of, we can't go back in time :)
> >
> > Where is this needed for 5.14-final, or for 5.15-rc1?
> >
>
> I would prefer to apply to 5.14-final. Just I need 1 more day to
> complete testing. Have I this additional day?

Sure, I'll drop this from my queue, please resubmit when you are ready
to have them reviewed/accepted.

Also, if these "fix" a previous patch, please put a "Fixes:" tag in the
patch so we know that.

thanks,

greg k-h