Re: [PATCH 6/6] staging: r8188eu: remove RT_TRACE and DBG_88E prints from xmit_linux.c

From: Greg Kroah-Hartman
Date: Thu Aug 05 2021 - 07:02:20 EST


On Tue, Aug 03, 2021 at 10:15:11PM +0200, Martin Kaiser wrote:
> We should use the standard mechanism for debug prints. Remove the prints
> that use driver-specific macros.

It is ok to remove the RT_TRACE macros, but you are removing the other
debugging calls and are not replacing them with anything.

Are you sure that is ok? Why not use the proper debugging calls instead
of just deleting them?

thanks,

greg k-h