Re: [PATCH v5 1/2] Bluetooth: btusb: Record debug log for Mediatek Chip.

From: Marcel Holtmann
Date: Thu Aug 05 2021 - 09:12:53 EST


Hi Tedd,

> I cannot find the original patch email and CI report, however this patch throws this warning.
>
> drivers/bluetooth/btusb.c: In function ‘btusb_recv_acl_mtk’:
> drivers/bluetooth/btusb.c:4033:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 4033 | usb_disable_autosuspend(data->udev);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/bluetooth/btusb.c:4034:2: note: here
> 4034 | case 0x05ff: /* Firmware debug logging 1 */
> | ^~~~

the /* fall through */ comment is missing.

Regards

Marcel