Re: [PATCH v1 1/1] wwan: core: Avoid returning error pointer from wwan_create_dev()

From: Loic Poulain
Date: Thu Aug 05 2021 - 15:44:27 EST


On Thu, 5 Aug 2021 at 20:38, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> wwan_create_dev() is expected to return either valid pointer or NULL,
> In some cases it might return the error pointer. Prevent this by converting
> it to NULL after wwan_dev_get_by_parent().

wwan_create_dev is called both from wwan_register_ops() and
wwan_create_port(), one using IS_ERR and the other using NULL testing,
they should be aligned as well.

Regards,
Loic