Re: [RFC PATCH v3.2 00/29] Add support UHS-II for GL9755

[Ulf Hansson]

On Fri, 6 Aug 2021 at 08:37, Lai Jason <jasonlai.genesyslogic@xxxxxxxxx> wrote:
>
> On Tue, 03 Aug 2021 at 12:23,   Ulf Hansson <ulf.hansson@xxxxxxxxxx>  wrote:
> >
> > On Thu, 22 Jul 2021 at 07:14, Jason Lai <jasonlai.genesyslogic@xxxxxxxxx> wrote:
> > >
> > > Summary
> > > =======
> > > In these patches we focus on uhs2 side to address Ulf's suggestion which
> > > was mentioned in patch [mmc: core: Preparations to support SD UHS-II cards].
> > >
> > >
> > > I moved codes in uhs2.c to proper functions in sd_uhs2.c, which should meet
> > > Ulf's expection.
> > >
> > > Please review this series (particularly Patch 29/29).
> >
> > I think you have misunderstood the intent with the series that I
> > posted [1] a while ago. The idea was to add the foundation of what
> > should be needed in the mmc core to support UHS-II cards. Note, it's
> > only the foundation, not the complete code.
> >
> > In other words, I think you should base the next version of $subject
> > series *on top* of my series [1], rather than the opposite.
> >
> Actually, I understand your intention is to implement functions which
> can be applied to control all UHS-II cards.
> However, why do I choose to base it on “[RFC,v3.1,00/27] Add support
> UHS-II for GL9755”?
> Because it contains a complete UHS-II interface(both host & card side)
> and UHS-II card can work normally.

It doesn't matter if things "work".

The code/patches need to be better organized than currently,
especially the changes for the mmc core, which is why I stepped in and
tried to help out earlier. Otherwise it is impossible for me to review
the changes, but also to maintain the code in the long run.

The sdhci part is likely a bit more mature as it has been reviewed and
iterated with Adrian/Ben/Akashi-san. However, new/more changes needed
when my suggested changes for the mmc core come into play.

[...]

Kind regards
Uffe