Re: [PATCH net-next 2/6] net: ipa: reorder netdev pointer assignments

From: Alex Elder
Date: Fri Aug 06 2021 - 07:40:03 EST


On 8/5/21 8:41 PM, Jakub Kicinski wrote:
On Thu, 5 Aug 2021 18:27:12 -0700 Jakub Kicinski wrote:
On Wed, 4 Aug 2021 10:36:22 -0500 Alex Elder wrote:
Assign the ipa->modem_netdev and endpoint->netdev pointers *before*
registering the network device. As soon as the device is
registered it can be opened, and by that time we'll want those
pointers valid.

Similarly, don't make those pointers NULL until *after* the modem
network device is unregistered in ipa_modem_stop().

Signed-off-by: Alex Elder <elder@xxxxxxxxxx>

This one seems like a pretty legit race, net would be better if you
don't mind.

Ah, this set was already applied, don't mind me :)

I really appreciate your review and feedback. Applied or not,
it's valuable to me.

-Alex