[PATCH v4 0/2] Add pinctrl support for Intel Keem Bay SoC
From: lakshmi . sowjanya . d
Date: Fri Aug 06 2021 - 10:25:34 EST
From: Lakshmi Sowjanya D <lakshmi.sowjanya.d@xxxxxxxxx>
Hi,
This patch set enables the support for the integrated pin controller in
the Intel Keem Bay SoC.
Patch 1 holds the implementation of pinctrl driver.
Patch 2 holds the relevant Device Tree bindings documentation and an
entry in MAINTAINERS file
High-Level Architecture:
-----------------------
+----------------------------+
------------------------------|MODE 0 - |
-----------------------------|MODE 1 PIN MUX |
----------------------------|... |
---------------------------|... | PAD M
+-------------------------|MODE 7(GPIO) -------
| | | .
| | +---------------------+ | .
| | | GPIO_MODE (0-79) | | .
| | | INV|PU|PD|DIR|MODE | | .
| | +---------------------+ | .
| | PIN CONFIGURATION | .
| +----------------------------+ .
| .
| +----------------------------+ .
| -----------------|MODE 0 - | .
| ----------------|MODE 1 PIN MUX | .
| ---------------|... |
| -------------|... | PAD N
| +--------|MODE 7(GPIO) -------
| | | |
| | | +---------------------+ |
| | | | GPIO_MODE (0-79) | |
| | | | INV|PU|PD|DIR|MODE | |
| | | +---------------------+ |
| | | PIN CONFIGURATION |
| | +----------------------------+
| |
| |
| |
| | +------------------------------------+
| | | GPIO PIN CONTROL |
| | | |
| | | +-------------------------+ |
| | | | GPIO_DATA_IN (0-2) | |
| | | +-------------------------+ |
0 1..28 29 30 31 ------- +-------------------------+ |
| | | | | | | | GPIO_DATA_OUT_HIGH (0-2)| |
\ \ \ \ \ | | | GPIO_DATA_OUT_LOW (0-2) | |
| | | | | | | +-------------------------+ |
| | | | | | | |
| | | | | | +------------------------------------+
\ \ \ \ \ |
| | | | | | GPIO_INT_CFG (Bits)
| | | | | | +---|-------|--|------|--|----|--|---+
+-------------------+-+ |31 30 23 16 15 14-8 7 6-0 |
| GPIO_INT_CFG(0-7) | +---|-------|--|------^--|----|--|---+
+---------------------+ |En Idx |En| Idx |En| Idx|En|Idx|
| | | | +---|-------|--|------|--|----|--|---+
0| 1|...6| 7|
| | | |
+-------------------+
| |
| |
| |
| |
| Interrupt |
| Control |
| |
| |
| |
| |
+-------------------+
Explored registering GPIOCHIP per 32 bits, from the IP there are
registers
for set/clear and read pins which falls under the category of per
register
handling 32 bits, but for other functionality like direction, config,
interrupt mux, there is a need to have customised solution.
Using gpiochip per 32 bits involves additional data structures, and
it has an impact in the device tree for all the users of these
PADs.
Spinlock is not required for all the operations like set/get as there
are separate for each. Configuring all the registers in a single driver
is preferred as it is easy to debug.
Please help to review this patch set.
Thanks in advance,
Sowjanya
Changes from v3:
- Initialized ret variable
Changes from v2:
- Removed unused variable trig
Changes from v1:
- Changed the boolean to true in yaml
- Removed spinlock for all the transactions except irq transactions
- Added standard ngpios instead of num-gpios
- Added gpiochip_generic_config() api
- Added check for IRQ_ENABLE and removed the check for the mask
IRQ_TYPE_SENSE_MASK
Lakshmi Sowjanya D (2):
dt-bindings: pinctrl: Add bindings for Intel Keembay pinctrl driver
pinctrl: Add Intel Keem Bay pinctrl driver
.../pinctrl/intel,pinctrl-keembay.yaml | 135 ++
MAINTAINERS | 5 +
drivers/pinctrl/Kconfig | 19 +
drivers/pinctrl/Makefile | 1 +
drivers/pinctrl/pinctrl-keembay.c | 1731 +++++++++++++++++
5 files changed, 1891 insertions(+)
create mode 100644 Documentation/devicetree/bindings/pinctrl/intel,pinctrl-keembay.yaml
create mode 100644 drivers/pinctrl/pinctrl-keembay.c
--
2.17.1