[jirislaby:devel 14/38] drivers/tty/tty_io.c:2814:32: warning: passing argument 2 of 'ld->ops->ioctl' makes integer from pointer without a cast

From: kernel test robot
Date: Fri Aug 06 2021 - 14:44:35 EST

Next message:
Previous message: Messages sorted by:
tree: git checkout ea5d828388883933b32d38377907d9e # save the attached .config to linux COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0
If you fix the issue, kindly add following Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):

drivers/tty/tty_io.c: In function 'tty_ioctl':
> drivers/tty/tty_io.c:2814:32: warning: 2814 | retval = ld->ops->ioctl(tty, | ^~~~
| |
| struct drivers/tty/tty_io.c:2814:32: note: expected drivers/tty/tty_io.c:2814:12: error: too 2814 | retval = ld->ops->ioctl(tty, | ^~

vim +2814 drivers/tty/tty_io.c

e8b70e7d3e86319 drivers/char/tty_io.c Alan Cox ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds 04f378b198da233 drivers/char/tty_io.c Alan Cox ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds d996b62a8df1d93 drivers/char/tty_io.c Nicholas Piggin d996b62a8df1d93 drivers/char/tty_io.c Nicholas Piggin ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds 6131ffaa1f09141 drivers/tty/tty_io.c Al Viro ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds e8b70e7d3e86319 drivers/char/tty_io.c Alan Cox ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds 9e98966c7bb9435 drivers/char/tty_io.c Alan Cox 9e98966c7bb9435 drivers/char/tty_io.c Alan Cox 9e98966c7bb9435 drivers/char/tty_io.c Alan Cox ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds 8f520021837d45c drivers/char/tty_io.c Alan Cox ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds fc6f6238226e6d1 drivers/char/tty_io.c Alan Cox ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds 84fd7bdf1266ee6 drivers/tty/tty_io.c Cyrill Gorcunov 84fd7bdf1266ee6 drivers/tty/tty_io.c Cyrill Gorcunov 84fd7bdf1266ee6 drivers/tty/tty_io.c Cyrill Gorcunov e73b240785f2845 drivers/tty/tty_io.c Xiaofei Tan 84fd7bdf1266ee6 drivers/tty/tty_io.c Cyrill Gorcunov 84fd7bdf1266ee6 drivers/tty/tty_io.c Cyrill Gorcunov ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds 5c17c861a357e94 drivers/tty/tty_io.c Peter Hurley ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds 3c95c985fa91ecf drivers/tty/tty_io.c Kay Sievers 3c95c985fa91ecf drivers/tty/tty_io.c Kay Sievers 3c95c985fa91ecf drivers/tty/tty_io.c Kay Sievers 3c95c985fa91ecf drivers/tty/tty_io.c Kay Sievers 3c95c985fa91ecf drivers/tty/tty_io.c Kay Sievers b7b8de087384cc1 drivers/tty/tty_io.c Werner Fink b7b8de087384cc1 drivers/tty/tty_io.c Werner Fink b7b8de087384cc1 drivers/tty/tty_io.c Werner Fink e73b240785f2845 drivers/tty/tty_io.c Xiaofei Tan b7b8de087384cc1 drivers/tty/tty_io.c Werner Fink b7b8de087384cc1 drivers/tty/tty_io.c Werner Fink ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds f34d7a5b7010b82 drivers/char/tty_io.c Alan Cox 9e98966c7bb9435 drivers/char/tty_io.c Alan Cox ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds f34d7a5b7010b82 drivers/char/tty_io.c Alan Cox 9e98966c7bb9435 drivers/char/tty_io.c Alan Cox ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds 283fef59d6e934e drivers/char/tty_io.c Paul Fulghum 283fef59d6e934e drivers/char/tty_io.c Paul Fulghum 283fef59d6e934e drivers/char/tty_io.c Paul Fulghum ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds b20f3ae5f0efe18 drivers/char/tty_io.c Domen Puncer ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds b20f3ae5f0efe18 drivers/char/tty_io.c Domen Puncer ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds 60b33c133ca0b7c drivers/tty/tty_io.c Alan Cox ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds 20b9d17715017ae drivers/tty/tty_io.c Alan Cox d281da7ff6f70ef drivers/char/tty_io.c Alan Cox a3096199226c2e4 drivers/tty/tty_io.c Al Viro c5c34d4862e18ef drivers/char/tty_io.c Paul Fulghum c5c34d4862e18ef drivers/char/tty_io.c Paul Fulghum c5c34d4862e18ef drivers/char/tty_io.c Paul Fulghum c5c34d4862e18ef drivers/char/tty_io.c Paul Fulghum c5c34d4862e18ef drivers/char/tty_io.c Paul Fulghum 86c80a8e2ab443e drivers/tty/tty_io.c Peter Hurley c5c34d4862e18ef drivers/char/tty_io.c Paul Fulghum c5c34d4862e18ef drivers/char/tty_io.c Paul Fulghum c5c34d4862e18ef drivers/char/tty_io.c Paul Fulghum 8a8ae62f8296760 drivers/tty/tty_io.c Jiri Slaby 930236a30897532 drivers/tty/tty_io.c Al Viro 2f46a2c1d4eb982 drivers/tty/tty_io.c Al Viro 930236a30897532 drivers/tty/tty_io.c Al Viro 311fc65c9fb9c96 drivers/tty/tty_io.c Eric 311fc65c9fb9c96 drivers/tty/tty_io.c Eric 311fc65c9fb9c96 drivers/tty/tty_io.c Eric a1235b3eb10086b drivers/tty/tty_io.c Nicolas Pitre a1235b3eb10086b drivers/tty/tty_io.c Nicolas Pitre a1235b3eb10086b drivers/tty/tty_io.c Nicolas Pitre a1235b3eb10086b drivers/tty/tty_io.c Nicolas Pitre ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds f34d7a5b7010b82 drivers/char/tty_io.c Alan Cox c961bfb17406c9f drivers/tty/tty_io.c Peter Hurley ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds e55afd11a48354c drivers/tty/tty_io.c Peter Hurley e55afd11a48354c drivers/tty/tty_io.c Peter Hurley ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds a352def21a64213 drivers/char/tty_io.c Alan Cox a352def21a64213 drivers/char/tty_io.c Alan Cox ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds bbb63c514a34643 drivers/tty/tty_io.c Wanlong Gao ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds ^1da177e4c3f415 drivers/char/tty_io.c Linus Torvalds
:::::: The code at line 2814 was first introduced :::::: a352def21a642133758b868c71bee12ab34ad5c5
:::::: TO: Alan Cox <alan@xxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxx
---
0-DAY CI Kernel Test Service, Intel Corporation
.config.gz< Description: application/gzip Heiner Kallweit: "Re: [PATCH 1/2] r8169: Implement dynamic ASPM mechanism" href="06539.html"> Miquel Raynal: "Re: [PATCH 04/13] mtd: spinand: Fix odd byte addr and data phase in read/write reg op and write VCR op for Octal DTR mode" href="date.html#06540">[ date ] [ thread ] [ subject ] [ author ] org/pub/scm/linux/kernel/git/jirislaby/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git devel
[14/38] tty: remove file from tty_ldisc_ops::ioctl and compat_ioctl
(attached as .config)
thubusercontent.com/intel/lkp-tests/master/sbin/make.cross">https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
l.org/pub/scm/linux/kernel/git/jirislaby/linux.git/commit/?id=ea5d828388883933b32d38377907d9ea0533f692">https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git/commit/?id=ea5d828388883933b32d38377907d9ea0533f692
href="https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git
a0533f692
build tree
make.cross ARCH=openrisc
tag as appropriate

> passing argument 2 of 'ld->ops->ioctl' makes integer from pointer without a cast [-Wint-conversion]
file, cmd, arg);
file *
'unsigned int' but argument is of type 'struct file *'
many arguments to function 'ld->ops->ioctl'
file, cmd, arg);
2009-06-11 2677
2005-04-16 2678 /*
2005-04-16 2679 * Split this up, as gcc can choke on it otherwise..
2005-04-16 2680 */
2008-04-30 2681 long tty_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
2005-04-16 2682 {
2010-08-18 2683 struct tty_struct *tty = file_tty(file);
2010-08-18 2684 struct tty_struct *real_tty;
2005-04-16 2685 void __user *p = (void __user *)arg;
2005-04-16 2686 int retval;
2005-04-16 2687 struct tty_ldisc *ld;
2005-04-16 2688
2013-02-27 2689 if (tty_paranoia_check(tty, file_inode(file), "tty_ioctl"))
2005-04-16 2690 return -EINVAL;
2005-04-16 2691
2009-06-11 2692 real_tty = tty_pair_get_tty(tty);
2005-04-16 2693
2005-04-16 2694 /*
2005-04-16 2695 * Factor out some common prep work
2005-04-16 2696 */
2005-04-16 2697 switch (cmd) {
2005-04-16 2698 case TIOCSETD:
2005-04-16 2699 case TIOCSBRK:
2005-04-16 2700 case TIOCCBRK:
2005-04-16 2701 case TCSBRK:
2005-04-16 2702 case TCSBRKP:
2005-04-16 2703 retval = tty_check_change(tty);
2005-04-16 2704 if (retval)
2005-04-16 2705 return retval;
2005-04-16 2706 if (cmd != TIOCCBRK) {
2005-04-16 2707 tty_wait_until_sent(tty, 0);
2005-04-16 2708 if (signal_pending(current))
2005-04-16 2709 return -EINTR;
2005-04-16 2710 }
2005-04-16 2711 break;
2005-04-16 2712 }
2005-04-16 2713
2008-07-22 2714 /*
2008-07-22 2715 * Now do the stuff.
2008-07-22 2716 */
2005-04-16 2717 switch (cmd) {
2005-04-16 2718 case TIOCSTI:
2005-04-16 2719 return tiocsti(tty, p);
2005-04-16 2720 case TIOCGWINSZ:
2008-10-13 2721 return tiocgwinsz(real_tty, p);
2005-04-16 2722 case TIOCSWINSZ:
2009-01-02 2723 return tiocswinsz(real_tty, p);
2005-04-16 2724 case TIOCCONS:
2005-04-16 2725 return real_tty != tty ? -EINVAL : tioccons(file);
2005-04-16 2726 case TIOCEXCL:
2005-04-16 2727 set_bit(TTY_EXCLUSIVE, &tty->flags);
2005-04-16 2728 return 0;
2005-04-16 2729 case TIOCNXCL:
2005-04-16 2730 clear_bit(TTY_EXCLUSIVE, &tty->flags);
2005-04-16 2731 return 0;
2012-10-24 2732 case TIOCGEXCL:
2012-10-24 2733 {
2012-10-24 2734 int excl = test_bit(TTY_EXCLUSIVE, &tty->flags);
2021-05-12 2735
2012-10-24 2736 return put_user(excl, (int __user *)p);
2012-10-24 2737 }
2005-04-16 2738 case TIOCGETD:
2016-01-10 2739 return tiocgetd(tty, p);
2005-04-16 2740 case TIOCSETD:
2005-04-16 2741 return tiocsetd(tty, p);
2011-02-17 2742 case TIOCVHANGUP:
2011-02-17 2743 if (!capable(CAP_SYS_ADMIN))
2011-02-17 2744 return -EPERM;
2011-02-17 2745 tty_vhangup(tty);
2011-02-17 2746 return 0;
2010-12-03 2747 case TIOCGDEV:
2010-12-03 2748 {
2010-12-03 2749 unsigned int ret = new_encode_dev(tty_devnum(real_tty));
2021-05-12 2750
2010-12-03 2751 return put_user(ret, (unsigned int __user *)p);
2010-12-03 2752 }
2005-04-16 2753 /*
2005-04-16 2754 * Break handling
2005-04-16 2755 */
2005-04-16 2756 case TIOCSBRK: /* Turn break on, unconditionally */
2008-04-30 2757 if (tty->ops->break_ctl)
2008-07-22 2758 return tty->ops->break_ctl(tty, -1);
2005-04-16 2759 return 0;
2005-04-16 2760 case TIOCCBRK: /* Turn break off, unconditionally */
2008-04-30 2761 if (tty->ops->break_ctl)
2008-07-22 2762 return tty->ops->break_ctl(tty, 0);
2005-04-16 2763 return 0;
2005-04-16 2764 case TCSBRK: /* SVID version: non-zero arg --> no break */
2006-06-27 2765 /* non-zero arg means wait for all output data
2006-06-27 2766 * to be sent (performed above) but don't send break.
2006-06-27 2767 * This is used by the tcdrain() termios function.
2005-04-16 2768 */
2005-04-16 2769 if (!arg)
2005-06-25 2770 return send_break(tty, 250);
2005-04-16 2771 return 0;
2005-04-16 2772 case TCSBRKP: /* support for POSIX tcsendbreak() */
2005-06-25 2773 return send_break(tty, arg ? arg*100 : 250);
2005-04-16 2774
2005-04-16 2775 case TIOCMGET:
2011-02-14 2776 return tty_tiocmget(tty, p);
2005-04-16 2777 case TIOCMSET:
2005-04-16 2778 case TIOCMBIC:
2005-04-16 2779 case TIOCMBIS:
2011-02-14 2780 return tty_tiocmset(tty, cmd, p);
2010-09-16 2781 case TIOCGICOUNT:
2018-09-12 2782 return tty_tiocgicount(tty, p);
2007-05-12 2783 case TCFLSH:
2007-05-12 2784 switch (arg) {
2007-05-12 2785 case TCIFLUSH:
2007-05-12 2786 case TCIOFLUSH:
2007-05-12 2787 /* flush tty buffer and allow ldisc to process ioctl */
2014-11-05 2788 tty_buffer_flush(tty, NULL);
2007-05-12 2789 break;
2007-05-12 2790 }
2007-05-12 2791 break;
2014-11-06 2792 case TIOCSSERIAL:
2018-09-12 2793 return tty_tiocsserial(tty, p);
2018-09-11 2794 case TIOCGSERIAL:
2018-09-12 2795 return tty_tiocgserial(tty, p);
W. Biederman 2017-08-24 2796 case TIOCGPTPEER:
W. Biederman 2017-08-24 2797 /* Special because the struct file is needed */
W. Biederman 2017-08-24 2798 return ptm_open_peer(file, tty, (int)arg);
2017-04-12 2799 default:
2017-04-12 2800 retval = tty_jobctrl_ioctl(tty, real_tty, file, cmd, arg);
2017-04-12 2801 if (retval != -ENOIOCTLCMD)
2017-04-12 2802 return retval;
2005-04-16 2803 }
2008-04-30 2804 if (tty->ops->ioctl) {
2014-11-05 2805 retval = tty->ops->ioctl(tty, cmd, arg);
2005-04-16 2806 if (retval != -ENOIOCTLCMD)
2005-04-16 2807 return retval;
2005-04-16 2808 }
2005-04-16 2809 ld = tty_ldisc_ref_wait(tty);
2016-01-10 2810 if (!ld)
2016-01-10 2811 return hung_up_tty_ioctl(file, cmd, arg);
2005-04-16 2812 retval = -EINVAL;
2008-07-16 2813 if (ld->ops->ioctl) {
2008-07-16 @2814 retval = ld->ops->ioctl(tty, file, cmd, arg);
2005-04-16 2815 if (retval == -ENOIOCTLCMD)
2012-08-27 2816 retval = -ENOTTY;
2005-04-16 2817 }
2005-04-16 2818 tty_ldisc_deref(ld);
2005-04-16 2819 return retval;
2005-04-16 2820 }
2005-04-16 2821
by commit
tty: Ldisc revamp
xxxxxxx>
itty/list/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
/strong>
- Next message: Heiner Kallweit: "Re: [PATCH 1/2] r8169: Implement dynamic ASPM mechanism"
- Previous message: Miquel Raynal: "Re: [PATCH 04/13] mtd: spinand: Fix odd byte addr and data phase in read/write reg op and write VCR op for Octal DTR mode"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]