Re: [PATCH] drm/amd/display: Remove redundant initialization of variable eng_id

[Alex Deucher]

Applied.  Thanks!

Alex

On Fri, Aug 6, 2021 at 7:16 AM Colin King <colin.king@xxxxxxxxxxxxx> wrote:
>
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The variable eng_id is being initialized with a value that is never
> read, it is being re-assigned on the next statment. The assignment
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c
> index 1a89d565c92e..de80a9ea4cfa 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c
> @@ -305,7 +305,7 @@ struct link_encoder *link_enc_cfg_get_next_avail_link_enc(
>         const struct dc_state *state)
>  {
>         struct link_encoder *link_enc = NULL;
> -       enum engine_id eng_id = ENGINE_ID_UNKNOWN;
> +       enum engine_id eng_id;
>
>         eng_id = find_first_avail_link_enc(dc->ctx, state);
>         if (eng_id != ENGINE_ID_UNKNOWN)
> --
> 2.31.1
>