Re: [PATCH 02/11] dt-bindings: usb: mtk-xhci: add optional property to disable usb2 ports

From: Rob Herring
Date: Fri Aug 06 2021 - 16:41:21 EST


On Fri, Jul 30, 2021 at 04:49:53PM +0800, Chunfeng Yun wrote:
> Add support to disable specific usb2 host ports, it's useful when
> a usb2 port is disabled on some platforms, but enabled on others for
> the same SoC, another case is that the different package may support
> different number of ports.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> index 49729aab6d1a..61a0e550b5d6 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> @@ -154,6 +154,11 @@ properties:
> description: The mask to disable u3ports, bit0 for u3port0,
> bit1 for u3port1, ... etc
>
> + mediatek,u2p-dis-msk:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: The mask to disable u2ports, bit0 for u2port0,
> + bit1 for u2port1, ... etc

You already have this property in the parent node, right? Why are we
duplicating it in both places?

Rob