Re: [PATCH v2 1/3] dt-bindings: rtc: Add Mstar MSC313e RTC devicetree bindings documentation

From: Rob Herring
Date: Fri Aug 06 2021 - 17:37:19 EST


On Sun, Aug 01, 2021 at 06:09:19PM +0200, Romain Perier wrote:
> This adds the documentation for the devicetree bindings of the Mstar
> MSC313e RTC driver, found from MSC313e SoCs and newer.
>
> Signed-off-by: Romain Perier <romain.perier@xxxxxxxxx>
> ---
> .../bindings/rtc/mstar,msc313-rtc.yaml | 49 +++++++++++++++++++
> 1 file changed, 49 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/mstar,msc313-rtc.yaml
>
> diff --git a/Documentation/devicetree/bindings/rtc/mstar,msc313-rtc.yaml b/Documentation/devicetree/bindings/rtc/mstar,msc313-rtc.yaml
> new file mode 100644
> index 000000000000..62bc12b1feb6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/mstar,msc313-rtc.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: GPL-2.0

As checkpatch.pl will tell you, should be dual licensed.

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/mstar,msc313-rtc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mstar MSC313e RTC Device Tree Bindings
> +
> +allOf:
> + - $ref: "rtc.yaml#"
> +
> +maintainers:
> + - Daniel Palmer <daniel@xxxxxxxx>
> + - Romain Perier <romain.perier@xxxxxxxxx>
> +
> +properties:
> + compatible:
> + enum:
> + - mstar,msc313-rtc
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + start-year: true
> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + rtc@2400 {
> + compatible = "mstar,msc313-rtc";
> + reg = <0x2400 0x40>;
> + clocks = <&xtal_div2>;
> + interrupts-extended = <&intc_irq GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +...
> --
> 2.30.2
>
>