Re: [PATCH v1 1/1] platform/x86/intel: int3472: Use y instead of objs in Makefile

[Daniel Scally]

Hi Andy

On 06/08/2021 16:49, Andy Shevchenko wrote:
> The 'objs' is for user space tools, for the kernel modules
> we should use 'y'.


Oops, now you mention it I remember you saying that for the cio2-bridge
code too - thanks.

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>


Reviewed-by: Daniel Scally <djrscally@xxxxxxxxx>

> ---
>  drivers/platform/x86/intel/int3472/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/int3472/Makefile b/drivers/platform/x86/intel/int3472/Makefile
> index 48bd97f0a04e..2362e04db18d 100644
> --- a/drivers/platform/x86/intel/int3472/Makefile
> +++ b/drivers/platform/x86/intel/int3472/Makefile
> @@ -1,5 +1,5 @@
>  obj-$(CONFIG_INTEL_SKL_INT3472)		+= intel_skl_int3472.o
> -intel_skl_int3472-objs			:= intel_skl_int3472_common.o \
> +intel_skl_int3472-y			:= intel_skl_int3472_common.o \
>  					   intel_skl_int3472_discrete.o \
>  					   intel_skl_int3472_tps68470.o \
>  					   intel_skl_int3472_clk_and_regulator.o