Re: [PATCH 2/2] mm/damon/Kconfig: Remove unnecessary PAGE_EXTENSION setup

[Randy Dunlap]

On 8/6/21 2:51 AM, SeongJae Park wrote:
> From: SeongJae Park <sjpark@xxxxxxxxx>
>
> Commit 13d49dbd0123 ("mm/damon: implement primitives for the virtual
> memory address spaces") of linux-mm[1] makes DAMON_VADDR to set
> PAGE_IDLE_FLAG.  PAGE_IDLE_FLAG sets PAGE_EXTENSION if !64BIT.  However,
> DAMON_VADDR do the same work again.  This commit removes the unnecessary
> duplicate.
>
> [1] https://github.com/hnaz/linux-mm/commit/13d49dbd0123
>
> Fixes: 13d49dbd0123 ("mm/damon: implement primitives for the virtual memory address spaces")
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Signed-off-by: SeongJae Park <sjpark@xxxxxxxxx>

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested

Thanks.

> ---
>   mm/damon/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig
> index 455995152697..37024798a97c 100644
> --- a/mm/damon/Kconfig
> +++ b/mm/damon/Kconfig
> @@ -27,7 +27,6 @@ config DAMON_KUNIT_TEST
>   config DAMON_VADDR
>   	bool "Data access monitoring primitives for virtual address spaces"
>   	depends on DAMON && MMU
> -	select PAGE_EXTENSION if !64BIT
>   	select PAGE_IDLE_FLAG
>   	help
>   	  This builds the default data access monitoring primitives for DAMON


--
~Randy