Re: [PATCH] uapi: expose enum pid_type

[kernel test robot]

Hi Eugene,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.14-rc4 next-20210806]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Eugene-Syromiatnikov/uapi-expose-enum-pid_type/20210807-090303
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c9194f32bfd932e976a158d1af97a63be68a2aab
config: arm64-randconfig-r025-20210804 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2bbca57c66637caced712672da1cce4441107353
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Eugene-Syromiatnikov/uapi-expose-enum-pid_type/20210807-090303
        git checkout 2bbca57c66637caced712672da1cce4441107353
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from include/linux/pid.h:5,
                    from include/uapi/linux/prctl.h:6,
                    from arch/arm64/include/asm/pointer_auth.h:6,
                    from arch/arm64/include/asm/processor.h:36,
                    from include/linux/rcupdate.h:30,
                    from include/linux/percpu-refcount.h:56,
                    from include/linux/memremap.h:6,
                    from drivers/dax/bus.c:3:
   include/linux/rculist.h: In function '__list_add_rcu':
>> include/linux/rculist.h:93:2: error: implicit declaration of function 'rcu_assign_pointer' [-Werror=implicit-function-declaration]
      93 |  rcu_assign_pointer(list_next_rcu(prev), new);
         |  ^~~~~~~~~~~~~~~~~~
   In file included from include/linux/string.h:262,
                    from include/linux/bitmap.h:10,
                    from include/linux/cpumask.h:12,
                    from include/linux/smp.h:13,
                    from include/linux/percpu.h:7,
                    from include/linux/percpu-refcount.h:55,
                    from include/linux/memremap.h:6,
                    from drivers/dax/bus.c:3:
   In function 'strncpy',
       inlined from 'do_id_store' at drivers/dax/bus.c:89:5:
   include/linux/fortify-string.h:27:30: warning: '__builtin_strncpy' specified bound 30 equals destination size [-Wstringop-truncation]
      27 | #define __underlying_strncpy __builtin_strncpy
         |                              ^
   include/linux/fortify-string.h:38:9: note: in expansion of macro '__underlying_strncpy'
      38 |  return __underlying_strncpy(p, q, size);
         |         ^~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from include/uapi/linux/prctl.h:6,
                    from arch/arm64/include/asm/pointer_auth.h:6,
                    from arch/arm64/include/asm/processor.h:36,
                    from include/asm-generic/qrwlock.h:14,
                    from ./arch/arm64/include/generated/asm/qrwlock.h:1,
                    from arch/arm64/include/asm/spinlock.h:9,
                    from include/linux/spinlock.h:90,
                    from include/linux/wait.h:9,
                    from include/linux/wait_bit.h:8,
                    from include/linux/fs.h:6,
                    from include/linux/debugfs.h:15,
                    from kernel/dma/pool.c:7:
>> include/linux/pid.h:70:2: error: unknown type name 'wait_queue_head_t'
      70 |  wait_queue_head_t wait_pidfd;
         |  ^~~~~~~~~~~~~~~~~


vim +/rcu_assign_pointer +93 include/linux/rculist.h

28875945ba98d1 Joel Fernandes (Google  2019-07-16  78) 
82524746c27fa4 Franck Bui-Huu          2008-05-12  79  /*
82524746c27fa4 Franck Bui-Huu          2008-05-12  80   * Insert a new entry between two known consecutive entries.
82524746c27fa4 Franck Bui-Huu          2008-05-12  81   *
82524746c27fa4 Franck Bui-Huu          2008-05-12  82   * This is only for internal list manipulation where we know
82524746c27fa4 Franck Bui-Huu          2008-05-12  83   * the prev/next entries already!
82524746c27fa4 Franck Bui-Huu          2008-05-12  84   */
82524746c27fa4 Franck Bui-Huu          2008-05-12  85  static inline void __list_add_rcu(struct list_head *new,
82524746c27fa4 Franck Bui-Huu          2008-05-12  86  		struct list_head *prev, struct list_head *next)
82524746c27fa4 Franck Bui-Huu          2008-05-12  87  {
54acd4397d7e7a Kees Cook               2016-08-17  88  	if (!__list_add_valid(new, prev, next))
54acd4397d7e7a Kees Cook               2016-08-17  89  		return;
54acd4397d7e7a Kees Cook               2016-08-17  90  
82524746c27fa4 Franck Bui-Huu          2008-05-12  91  	new->next = next;
82524746c27fa4 Franck Bui-Huu          2008-05-12  92  	new->prev = prev;
67bdbffd696f29 Arnd Bergmann           2010-02-25 @93  	rcu_assign_pointer(list_next_rcu(prev), new);
82524746c27fa4 Franck Bui-Huu          2008-05-12  94  	next->prev = new;
82524746c27fa4 Franck Bui-Huu          2008-05-12  95  }
82524746c27fa4 Franck Bui-Huu          2008-05-12  96  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip