Re: [PATCH 5.13 32/35] Revert "spi: mediatek: fix fifo rx mode"

From: Greg Kroah-Hartman
Date: Sat Aug 07 2021 - 04:21:25 EST


On Fri, Aug 06, 2021 at 11:54:08AM -0700, Guenter Roeck wrote:
> On 8/6/21 1:17 AM, Greg Kroah-Hartman wrote:
> > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> >
> > This reverts commit 09b8cc7810587257e5f82080884001301e1a1ba9 which is
> > commit 3a70dd2d050331ee4cf5ad9d5c0a32d83ead9a43 upstream.
> >
> > It has been found to have problems.
> >
> > Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > Cc: Peter Hess <peter.hess@xxxxxxxxxx>
> > Cc: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> > Cc: Mark Brown <broonie@xxxxxxxxxx>
> > Cc: Sasha Levin <sashal@xxxxxxxxxx>
> > Link: https://lore.kernel.org/r/efee3a58-a4d2-af22-0931-e81b877ab539@xxxxxxxxxxxx
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> The problem with the reverted patch has now been fixed in the mainline
> kernel with commit 0d5c3954b35e ("spi: mediatek: Fix fifo transfer").
> So an alternative to this revert might be to apply commit 0d5c3954b35e
> instead.

Good idea, I'll go drop this revert and add that change instead.

thanks,

greg k-h