Re: [PATCH 2/2] iio: potentiometer: Add driver support for AD5110
From: Mugilraj Dhavachelvan
Date: Sat Aug 07 2021 - 13:29:22 EST
On 07/08/21 5:47 pm, Lars-Peter Clausen wrote:
> On 8/7/21 7:08 AM, Mugilraj Dhavachelvan wrote:
>> +static const struct iio_chan_spec ad5110_channels[] = {
>> + {
>> + .type = IIO_RESISTANCE,
>> + .output = 1,
>> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_OFFSET),
>> + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE) |
>> + BIT(IIO_CHAN_INFO_ENABLE),
> There is only on channel in this device. Why are some `separate` and others `shared_by_type`?
>
No special reason, I'll put everything into 'separate'. Fixed in v2.
>