[PATCH] ipv4: fix error path in fou_create()

From: Kangmin Park
Date: Sat Aug 07 2021 - 23:27:54 EST


kzalloc() to allocate fou is never called when udp_sock_create()
is failed. So, fou is always NULL in error label in this case.

Therefore, add a error_sock label and goto this label when
udp_sock_screate() is failed.

Signed-off-by: Kangmin Park <l4stpr0gr4m@xxxxxxxxx>
---
net/ipv4/fou.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c
index e5f69b0bf3df..60d67ae76880 100644
--- a/net/ipv4/fou.c
+++ b/net/ipv4/fou.c
@@ -572,7 +572,7 @@ static int fou_create(struct net *net, struct fou_cfg *cfg,
/* Open UDP socket */
err = udp_sock_create(net, &cfg->udp_config, &sock);
if (err < 0)
- goto error;
+ goto error_sock;

/* Allocate FOU port structure */
fou = kzalloc(sizeof(*fou), GFP_KERNEL);
@@ -627,9 +627,9 @@ static int fou_create(struct net *net, struct fou_cfg *cfg,

error:
kfree(fou);
+error_sock:
if (sock)
udp_tunnel_sock_release(sock);
-
return err;
}

--
2.26.2