Re: [PATCH] arm64: zynqmp: Remove not documented is-dual property

From: Laurent Pinchart
Date: Sun Aug 08 2021 - 21:52:25 EST


Hi Michal,

Thank you for the patch.

On Fri, Aug 06, 2021 at 10:42:29AM +0200, Michal Simek wrote:
> Remove is-dual not documented property and also update comment about QSPI
> sizes to reflect dual configuration as 16MB + 16MB.
> Only single configuration is supported now.
>
> Reported-by: Quanyang Wang <quanyang.wang@xxxxxxxxxxxxx>
> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
>
> arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 3 +--
> arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts | 3 +--
> arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts | 3 +--
> 3 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> index becfc23a5610..3d8d14ef1ede 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> @@ -937,9 +937,8 @@ &psgtr {
>
> &qspi {
> status = "okay";
> - is-dual = <1>;
> flash@0 {
> - compatible = "m25p80", "jedec,spi-nor"; /* 32MB */
> + compatible = "m25p80", "jedec,spi-nor"; /* 16MB + 16MB */
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0x0>;
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> index d2219373580a..057c04352591 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> @@ -931,9 +931,8 @@ &psgtr {
>
> &qspi {
> status = "okay";
> - is-dual = <1>;
> flash@0 {
> - compatible = "m25p80", "jedec,spi-nor"; /* 32MB */
> + compatible = "m25p80", "jedec,spi-nor"; /* 16MB + 16MB */
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0x0>;
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
> index dac5ba67a160..e1fff62a4cd5 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
> @@ -773,9 +773,8 @@ &psgtr {
>
> &qspi {
> status = "okay";
> - is-dual = <1>;
> flash@0 {
> - compatible = "m25p80", "jedec,spi-nor"; /* 32MB */
> + compatible = "m25p80", "jedec,spi-nor"; /* 16MB + 16MB */
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0x0>;

--
Regards,

Laurent Pinchart