Re: [PATCH 3/3] mm/gup: refactor and simplify try_get_page()

From: Christoph Hellwig
Date: Mon Aug 09 2021 - 02:32:00 EST


On Sun, Aug 08, 2021 at 04:50:18PM -0700, John Hubbard wrote:
> +/*
> + * This has the same functionality as try_get_compound_head(), just with a
> + * slightly different API.
> + */
> static inline __must_check bool try_get_page(struct page *page)
> {
> + return try_get_compound_head(page, 1) != NULL;

What about removing try_get_page entirely instead?