Re: [PATCH v3 2/7] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set

[Matthias Schiffer]

On Thu, 2021-08-05 at 16:42 +0300, Andy Shevchenko wrote:
> On Thu, Aug 5, 2021 at 4:40 PM Matthias Schiffer
> <matthias.schiffer@xxxxxxxxxxxxxxx> wrote:
> > On Thu, 2021-08-05 at 14:30 +0100, Lee Jones wrote:
> > > On Fri, 16 Jul 2021, Matthias Schiffer wrote:
> 
> ...
> 
> > > Strange - why is this !0 in the first place?
> > 
> > I don't see anything strange here. DEFINE_RES_IRQ() sets flags to
> > IORESOURCE_IRQ. We reset it to 0 when there is no IRQ to clear that
> > resource entry.
> > 
> > An alternative would be to start with an empty entry and only fill in
> > the fields when an IRQ is used, but that seems more cumbersome than the
> > current code to me.
> 
> Another alternative is to start using the IRQ DISABLED resource flag,
> but I'm afraid that OF code is not ready for that.
> https://elixir.bootlin.com/linux/latest/source/include/linux/ioport.h#L331
> 

As this patch is a fairly simple bugfix, I'd prefer to get it (or a
similar fix) applied without having to wait for improvements of the
core code - also for the sake of stable backports.