Re: [PATCH v6 00/12] mm/debug_vm_pgtable: Enhancements

[Christophe Leroy]

Le 09/08/2021 à 11:26, Gavin Shan a écrit :
> There are couple of issues with current implementations and this series
> tries to resolve the issues:
>
>    (a) All needed information are scattered in variables, passed to various
>        test functions. The code is organized in pretty much relaxed fashion.
>
>    (b) The page isn't allocated from buddy during page table entry modifying
>        tests. The page can be invalid, conflicting to the implementations
>        of set_xxx_at() on ARM64. The target page is accessed so that the
>        iCache can be flushed when execution permission is given on ARM64.
>        Besides, the target page can be unmapped and accessing to it causes
>        kernel crash.
>
> "struct pgtable_debug_args" is introduced to address issue (a). For issue
> (b), the used page is allocated from buddy in page table entry modifying
> tests. The corresponding tets will be skipped if we fail to allocate the
> (huge) page. For other test cases, the original page around to kernel
> symbol (@start_kernel) is still used.
>
> The patches are organized as below. PATCH[2-10] could be combined to one
> patch, but it will make the review harder:
>
>    PATCH[1] introduces "struct pgtable_debug_args" as place holder of all
>             needed information. With it, the old and new implementation
>             can coexist.
>    PATCH[2-10] uses "struct pgtable_debug_args" in various test functions.
>    PATCH[11] removes the unused code for old implementation.
>    PATCH[12] fixes the issue of corrupted page flag for ARM64


I tested this series on powerpc 8xx, no failure reported.

Christophe

> Changelog
> =========
> v6:
>     * Populate saved page table entry pointers after
>       they're allocated in init_args()                        (Anshuman)
>     * Fix imbalanced preemption count issue by replacing
>       pte_alloc_mmap() with pte_alloc() in init_args()        (syzbot)
> v5:
>     * Pick r-bs from Anshuman and rebase to 5.14.rc4          (Gavin)
>     * Use args->start_p4dp to free p4d entries                (Anshuman)
>     * Introduce helper to allocate huge page in init_arg()    (Anshuman)
>     * Bail early if the allocated page doesn't exist in
>       swap_migration_tests() and correct the comments         (Anshuman)
>     * Add fixes tag to PATCH[v4 12/12]                        (Christophe)
>     * Address misc comments                                   (Anshuman)
> v4:
>     * Determine the page allocation method according to
>       MAX_ORDER                                               (Anshuman)
>     * Move existing comments to init_args()                   (Anshuman)
>     * Code refactoring as suggested by Anshuman               (Anshuman)
>     * Improved commit log and add comments for flush_dcache_page()
>       in PATCH[v4 12/12]                                      (Anshuman)
>     * Address misc comments                                   (Anshuman)
> v3:
>     * Fix the warning caused by allocating more pages than
>       (1 << (MAX_ORDER - 1)) in init_args()                   (syzbot)
>     * Fix build warning by dropping unused variables in separate
>       patches                                                 (0-day)
>     * Missed "WARN_ON(!pud_none(pud))" in pud_huge_tests() in
>       PATCH[v2 09/12]                                         (0-day)
>     * Fix the subjects for PATCH[05/12] and PATCH[09/12]      (Gavin)
> v2:
>     * Rename struct vm_pgtable_debug to struct pgtable_debug_args.
>       The parameter name to various test functions are renamed
>       to "@args"                                              (Anshuman)
>     * Code changes as suggested by Anshuman                   (Anshuman)
>
> Gavin Shan (12):
>    mm/debug_vm_pgtable: Introduce struct pgtable_debug_args
>    mm/debug_vm_pgtable: Use struct pgtable_debug_args in basic tests
>    mm/debug_vm_pgtable: Use struct pgtable_debug_args in leaf and
>      savewrite tests
>    mm/debug_vm_pgtable: Use struct pgtable_debug_args in protnone and
>      devmap tests
>    mm/debug_vm_pgtable: Use struct pgtable_debug_args in soft_dirty and
>      swap tests
>    mm/debug_vm_pgtable: Use struct pgtable_debug_args in migration and
>      thp tests
>    mm/debug_vm_pgtable: Use struct pgtable_debug_args in PTE modifying
>      tests
>    mm/debug_vm_pgtable: Use struct pgtable_debug_args in PMD modifying
>      tests
>    mm/debug_vm_pgtable: Use struct pgtable_debug_args in PUD modifying
>      tests
>    mm/debug_vm_pgtable: Use struct pgtable_debug_args in PGD and P4D
>      modifying tests
>    mm/debug_vm_pgtable: Remove unused code
>    mm/debug_vm_pgtable: Fix corrupted page flag
>
>   mm/debug_vm_pgtable.c | 918 +++++++++++++++++++++++++-----------------
>   1 file changed, 559 insertions(+), 359 deletions(-)