RE: [PATCH v3] IB/hfi1: Fix possible null-pointer dereference in _extend_sdma_tx_descs()
From: Marciniszyn, Mike
Date: Mon Aug 09 2021 - 09:15:51 EST
> Fixes: 7724105686e7 ("IB/hfi1: add driver files")
> Reported-by: TOTE Robot <oslab@xxxxxxxxxxxxxxx>
> Signed-off-by: Tuo Li <islituo@xxxxxxxxx>
> ---
> v3:
> * Add fixes line.
> Thank Jason Gunthorpe for helpful advice.
> v2:
> * Assign the return value of kmalloc_array() to a local variable and then check
> it instead of assigning 0 to tx->num_desc when memory allocation fails.
> Thank Mike Marciniszyn for helpful advice.
Thanks!
I'm curious, did you find this with some fault injection testing?
Tested-by: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxxxxxxxxxxxxx>
Acked-by: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxxxxxxxxxxxxx>