Re: [PATCH v4 1/3] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/G2L SoC
From: Marc Kleine-Budde
Date: Mon Aug 09 2021 - 09:26:29 EST
On 27.07.2021 14:30:20, Lad Prabhakar wrote:
> Add CANFD binding documentation for Renesas RZ/G2L SoC.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> .../bindings/net/can/renesas,rcar-canfd.yaml | 69 +++++++++++++++++--
> 1 file changed, 63 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> index 0b33ba9ccb47..546c6e6d2fb0 100644
> --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> @@ -30,13 +30,15 @@ properties:
> - renesas,r8a77995-canfd # R-Car D3
> - const: renesas,rcar-gen3-canfd # R-Car Gen3 and RZ/G2
>
> + - items:
> + - enum:
> + - renesas,r9a07g044-canfd # RZ/G2{L,LC}
> + - const: renesas,rzg2l-canfd # RZ/G2L family
> +
> reg:
> maxItems: 1
>
> - interrupts:
> - items:
> - - description: Channel interrupt
> - - description: Global interrupt
> + interrupts: true
>
> clocks:
> maxItems: 3
> @@ -50,8 +52,7 @@ properties:
> power-domains:
> maxItems: 1
>
> - resets:
> - maxItems: 1
> + resets: true
>
> renesas,no-can-fd:
> $ref: /schemas/types.yaml#/definitions/flag
> @@ -91,6 +92,62 @@ required:
> - channel0
> - channel1
>
> +if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,rzg2l-canfd
> +then:
> + properties:
> + interrupts:
> + items:
> + - description: CAN global error interrupt
> + - description: CAN receive FIFO interrupt
> + - description: CAN0 error interrupt
> + - description: CAN0 transmit interrupt
> + - description: CAN0 transmit/receive FIFO receive completion interrupt
> + - description: CAN1 error interrupt
> + - description: CAN1 transmit interrupt
> + - description: CAN1 transmit/receive FIFO receive completion interrupt
> +
> + interrupt-names:
> + items:
> + - const: g_err
> + - const: g_recc
> + - const: ch0_err
> + - const: ch0_rec
> + - const: ch0_trx
> + - const: ch1_err
> + - const: ch1_rec
> + - const: ch1_trx
> +
> + resets:
> + maxItems: 2
> +
> + reset-names:
> + items:
> + - const: rstp_n
> + - const: rstc_n
> +
> + required:
> + - interrupt-names
> + - reset-names
> +else:
> + properties:
> + interrupts:
> + items:
> + - description: Channel interrupt
> + - description: Global interrupt
> +
> + interrupt-names:
> + items:
> + - const: ch_int
> + - const: g_int
Are you adding the new interrupt-names to the existing DTs, too?
Otherwise this patch will generate more warnings in the existing DTs.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature