Re: [V4 1/3] dt-bindings: interconnect: Add EPSS L3 DT binding on SC7280

[okukatla]

Thanks Stephen for the reviews!

On 2021-07-09 04:52, Stephen Boyd wrote:
> Quoting Odelu Kukatla (2021-06-18 04:28:52)
> > Add Epoch Subsystem (EPSS) L3 interconnect provider binding on SC7280
> > SoCs.
> >
> > Signed-off-by: Odelu Kukatla <okukatla@xxxxxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/interconnect/qcom,osm-l3.yaml          |  9 
> > ++++++++-
> >  include/dt-bindings/interconnect/qcom,osm-l3.h                 | 10 
> > +++++++++-
> >  2 files changed, 17 insertions(+), 2 deletions(-)
> >
> > diff --git 
> > a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml 
> > b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
> > index d6a95c3..9f67c8e 100644
> > --- a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
> > +++ b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
> > @@ -18,12 +18,19 @@ properties:
> >    compatible:
> >      enum:
> >        - qcom,sc7180-osm-l3
> > +      - qcom,sc7280-epss-l3
> >        - qcom,sdm845-osm-l3
> >        - qcom,sm8150-osm-l3
> >        - qcom,sm8250-epss-l3
> >
> >    reg:
> > -    maxItems: 1
> > +    minItems: 1
> > +    maxItems: 4
>
> Can we base this on the compatible string so that only sc7280-epss-l3
> requires 4 items? and then the others require 1 reg property?
Done, Addressing this in new revision.
> > +    items:
> > +      - description: OSM clock domain-0 base address and size
> > +      - description: OSM clock domain-1 base address and size
> > +      - description: OSM clock domain-2 base address and size
> > +      - description: OSM clock domain-3 base address and size
> >
> >    clocks:
> >      items: