Re: [PATCH] mailmap: update email address of Matthias Fuchs
From: Stefan Mätje
Date: Mon Aug 09 2021 - 13:22:59 EST
Am Montag, den 09.08.2021, 09:24 +0200 schrieb Marc Kleine-Budde:
> On 06.08.2021 15:07:43, Stefan Mätje wrote:
> > I was not aware of the .mailmap file and its workings.
> The mailmap file works on the git log, and thus tools using it: e.g.
> > My question is should then also <thomas.koerper@xxxxxx> be put in this
> > file
> Probably yes, as there are two patches by him in the Linux kernel:
> > Thomas Körper (2):
> > can: dev: avoid calling kfree_skb() from interrupt context
> > can: esd_usb2: Fix sparse warnings
> I'll update this patch.
> > because he is the co-author of the patch you're reviewing atm.
> For co-authorship, use the Co-developed-by tag, that was recently added:
I will do that.
> Speaking of that patch. Can you please create an entry in the
> MAINTAINERS file, too? I suggest to add yourself as M: and the
> firstname.lastname@example.org as R:. The change in the MAINTAINERS file will be a second
> patch in that series. Just include it the next iteration of that series.
Do you think of something like the patch below? I'm curious. Shouldn't there
be similar entries for the drivers from Vincent (drivers/net/can/usb/etas_es58x/)
and the PEAK driver family (drivers/net/can/peak_canfd/)? Why are they not there?
Have I misunderstood something?
diff --git a/MAINTAINERS b/MAINTAINERS
index 41fcfdb24a81..f25e3f79b392 100644
@@ -4111,6 +4111,14 @@ F: include/uapi/linux/can/error.h
+CAN NETWORK DRIVERS ESD HARDWARE
+M: Stefan Mätje <stefan.maetje@xxxxxx>
CAN NETWORK LAYER
M: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>
M: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> > and his email address shows up in MODULE_AUTHOR() macro. He also left
> > our company already.
> In newly added changes, it makes sense that all email addresses are
> working. :D
So I'll remove his stale email address together with the MODULE_AUTHOR() macro
and file the authorship credits in a changed copyright history at the top of
the source files.