Re: [PATCH] staging: r8188eu: remove rtw_ioctl function
From: Arnd Bergmann
Date: Tue Aug 10 2021 - 04:09:18 EST
On Tue, Aug 10, 2021 at 9:45 AM Phillip Potter <phil@xxxxxxxxxxxxxxxx> wrote:
> -int rtw_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
> -{
> - struct iwreq *wrq = (struct iwreq *)rq;
> - int ret = 0;
> -
> - switch (cmd) {
> - case RTL_IOCTL_WPA_SUPPLICANT:
> - ret = wpa_supplicant_ioctl(dev, &wrq->u.data);
> - break;
> -#ifdef CONFIG_88EU_AP_MODE
> - case RTL_IOCTL_HOSTAPD:
> - ret = rtw_hostapd_ioctl(dev, &wrq->u.data);
> - break;
> -#endif /* CONFIG_88EU_AP_MODE */
> - case SIOCDEVPRIVATE:
> - ret = rtw_ioctl_wext_private(dev, &wrq->u);
> - break;
I think these functions are all defined 'static' in the same file, so
removing the
caller will cause a warning about an unused function. Better remove the
called functions along with the caller.
Arnd