Re: [PATCH V3 01/13] x86/HV: Initialize GHCB page in Isolation VM

From: Tianyu Lan
Date: Tue Aug 10 2021 - 08:18:00 EST


Hi Wei:
Thanks for review.

On 8/10/2021 6:56 PM, Wei Liu wrote:
On Mon, Aug 09, 2021 at 01:56:05PM -0400, Tianyu Lan wrote:
[...]
static int hv_cpu_init(unsigned int cpu)
{
union hv_vp_assist_msr_contents msr = { 0 };
@@ -85,6 +111,8 @@ static int hv_cpu_init(unsigned int cpu)
}
}
+ hyperv_init_ghcb();
+

Why is the return value not checked here? If that's not required, can
you leave a comment?


The check is necessary here. Will update in the next version.

Thanks.