Re: [PATCH 2/5] KVM: arm64: Drop init_common_resources()

From: Will Deacon
Date: Tue Aug 10 2021 - 09:21:57 EST


On Tue, Aug 10, 2021 at 12:32:38PM +0530, Anshuman Khandual wrote:
> Could do without this additional indirection via init_common_resources() by
> just calling kvm_set_ipa_limit() directly instead. This change saves memory
> and cycles.

Does it? Really?

Will

> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> index e9a2b8f27792..19560e457c11 100644
> --- a/arch/arm64/kvm/arm.c
> +++ b/arch/arm64/kvm/arm.c
> @@ -1696,11 +1696,6 @@ static bool init_psci_relay(void)
> return true;
> }
>
> -static int init_common_resources(void)
> -{
> - return kvm_set_ipa_limit();
> -}
> -
> static int init_subsystems(void)
> {
> int err = 0;
> @@ -2102,7 +2097,7 @@ int kvm_arch_init(void *opaque)
> }
> }
>
> - err = init_common_resources();
> + err = kvm_set_ipa_limit();
> if (err)
> return err;
>
> --
> 2.20.1
>