Re: [PATCH] softirq: Remove the unnecessary CONFIG_TRACE_IRQFLAGS

[Thomas Gleixner]

On Wed, Jun 02 2021 at 10:53, Kees Cook wrote:
> On Wed, Jun 02, 2021 at 03:34:42PM +0800, Yejune Deng wrote:
>> The local_irq_enable() and local_irq_disable() had two definitions that
>> include CONFIG_TRACE_IRQFLAGS or not.
>
> Hm, this has a behavioral change. Current code only does tracing and
> raw_local_irq_disable/enable when CONFIG_TRACE_IRQFLAGS. This change
> causes it to always do raw_local_irq_disable/enable. Which is the right
> behavior?

Disabling interrupts is only required when CONFIG_TRACE_IRQFLAGS=y. So
the code is correct as is.

Thanks,

        tglx