Re: [PATCH v14 031/138] fs/netfs: Add folio fscache functions
From: David Howells
Date: Tue Aug 10 2021 - 11:40:39 EST
Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> wrote:
> Match the page writeback functions by adding
> folio_start_fscache(), folio_end_fscache(), folio_wait_fscache() and
> folio_wait_fscache_killable(). Remove set_page_private_2(). Also rewrite
> the kernel-doc to describe when to use the function rather than what the
> function does, and include the kernel-doc in the appropriate rst file.
> Saves 31 bytes of text in netfs_rreq_unlock() due to set_page_fscache()
> calling page_folio() once instead of three times.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
> Reviewed-by: William Kucharski <william.kucharski@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
Assuming you fixed the kernel test robot report:
Reviewed-by: David Howells <dhowells@xxxxxxxxxx>