Re: [PATCH] fpga: machxo2-spi: return an error on failure

From: Dan Carpenter
Date: Tue Aug 10 2021 - 14:51:47 EST


On Tue, Aug 10, 2021 at 07:06:09PM +0200, Greg KH wrote:
> On Tue, Aug 10, 2021 at 09:40:36AM -0700, trix@xxxxxxxxxx wrote:
> > From: Tom Rix <trix@xxxxxxxxxx>
> >
> > Reported problem
> >
> > drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
> > warn: missing error code 'ret'
> >
> > drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
> > warn: missing error code 'ret'
>
> What reported this? What does it mean? Where was it reported?

These are Smatch errors, but my bug reports don't mention Smatch so
that's on me. I've fixed my report templated to mention Smatch now.

regards,
dan carepenter