Re: [PATCH v14 035/138] mm/memcg: Use the node id in mem_cgroup_update_tree()

[David Howells]

Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> wrote:

> By using the node id in mem_cgroup_update_tree(), we can delete
> soft_limit_tree_from_page() and mem_cgroup_page_nodeinfo().  Saves 42
> bytes of kernel text on my config.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> Acked-by: Michal Hocko <mhocko@xxxxxxxx>
> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: David Howells <dhowells@xxxxxxxxxx>

Though I wonder if:

> -		mz = mem_cgroup_page_nodeinfo(memcg, page);
> +		mz = memcg->nodeinfo[nid];

should still have some sort of wrapper function.