Re: [PATCH v14 066/138] mm/writeback: Add __folio_end_writeback()

From: David Howells
Date: Tue Aug 10 2021 - 17:16:17 EST


Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> wrote:

> test_clear_page_writeback() is actually an mm-internal function, although
> it's named as if it's a pagecache function. Move it to mm/internal.h,
> rename it to __folio_end_writeback() and change the return type to bool.
>
> The conversion from page to folio is mostly about accounting the number
> of pages being written back, although it does eliminate a couple of
> calls to compound_head().
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: David Howells <dhowells@xxxxxxxxxx>