Re: [PATCH v14 067/138] mm/writeback: Add folio_start_writeback()

From: David Howells
Date: Tue Aug 10 2021 - 17:17:11 EST


Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> wrote:

> Rename set_page_writeback() to folio_start_writeback() to match
> folio_end_writeback(). Do not bother with wrappers that return void;
> callers are perfectly capable of ignoring return values.
>
> Add wrappers for set_page_writeback(), set_page_writeback_keepwrite() and
> test_set_page_writeback() for compatibililty with existing filesystems.
> The main advantage of this patch is getting the statistics right,
> although it does eliminate a couple of calls to compound_head().
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: David Howells <dhowells@xxxxxxxxxx>