[BUG] staging: rtl8192e: possible null-pointer dereference in rtllib_wx_set_encode()

From: Tuo Li
Date: Tue Aug 10 2021 - 23:34:05 EST


Hello,

Our static analysis tool finds a possible null-pointer dereference in rtllib_wx.c in Linux 5.14.0-rc3:

The variable (*crypt)->ops is checked in:
342:    if (*crypt && (*crypt)->ops && strcmp((*crypt)->ops->name, "R-WEP") != 0)

This indicates that it can be NULL. If so, null-pointer dereferences will occur:
389:    (*crypt)->ops->set_key()
400:    len = (*crypt)->ops->get_key()

I am not quite sure whether this possible null-pointer dereference is real and how to fix it if it is real.
Any feedback would be appreciated, thanks!

Reported-by: TOTE Robot <oslab@xxxxxxxxxxxxxxx>

Best wishes,
Tuo Li