Re: [PATCH -next] spi: mxic: add missing braces

From: zhengxunli
Date: Wed Aug 11 2021 - 00:06:48 EST


"Yang Yingliang" <yangyingliang@xxxxxxxxxx> wrote on 2021/08/10 下午
10:24:05:

> "Yang Yingliang" <yangyingliang@xxxxxxxxxx>
> 2021/08/10 下午 10:18
>
> To
>
> <linux-kernel@xxxxxxxxxxxxxxx>, <linux-spi@xxxxxxxxxxxxxxx>,
>
> cc
>
> <broonie@xxxxxxxxxx>, <zhengxunli@xxxxxxxxxxx>
>
> Subject
>
> [PATCH -next] spi: mxic: add missing braces
>
> Fix the following waring:
>
> drivers/spi/spi-mxic.c: In function ‘mxic_spi_mem_exec_op’:
> drivers/spi/spi-mxic.c:401:3: warning: this ‘if’ clause does not
> guard... [-Wmisleading-indentation]
> if (op->data.dir == SPI_MEM_DATA_IN)
> ^~
> drivers/spi/spi-mxic.c:403:4: note: ...this statement, but the
> latter is misleadingly indented as if it were guarded by the ‘if’
> if (op->data.dtr)
> ^~
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>

Reviewed-by: Zhengxun Li <zhengxunli@xxxxxxxxxxx>

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information
and/or personal data, which is protected by applicable laws. Please be
reminded that duplication, disclosure, distribution, or use of this e-mail
(and/or its attachments) or any part thereof is prohibited. If you receive
this e-mail in error, please notify us immediately and delete this mail as
well as its attachment(s) from your system. In addition, please be
informed that collection, processing, and/or use of personal data is
prohibited unless expressly permitted by personal data protection laws.
Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================



============================================================================

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================