Re: [PATCH v4 2/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for HDMI

From: Stephen Boyd
Date: Wed Aug 11 2021 - 02:06:23 EST


Quoting Srinivasa Rao Mandadapu (2021-07-21 01:05:49)
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 31bf7c698b8f..a4cb9ee567ff 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -288,6 +288,7 @@ sound: sound {
> "Headphone Jack", "HPOL",
> "Headphone Jack", "HPOR";
>
> + #sound-dai-cells = <0>;
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -314,6 +315,18 @@ sound_multimedia1_codec: codec {
> sound-dai = <&max98357a>;
> };
> };
> +
> + dai-link@2 {
> + link-name = "MultiMedia2";
> + reg = <2>;

Should this be

reg = <LPASS_DP_RX>;

? And then the dai-link@2 should change to dai-link@5? It doesn't seem
to really matter though, so maybe not.

> + cpu {
> + sound-dai = <&lpass_cpu 2>;

This should be

sound-dai = <&lpass_cpu LPASS_DP_RX>;

? At least from what I can tell without having it be 5 it doesn't work
properly and external audio over DP doesn't enumerate.

> + };
> +
> + codec {
> + sound-dai = <&mdss_dp>;
> + };
> + };
> };
> };
>
> @@ -768,6 +781,10 @@ secondary_mi2s: mi2s@1 {
> reg = <MI2S_SECONDARY>;
> qcom,playback-sd-lines = <0>;
> };
> +
> + hdmi-primary@0 {

This should be hdmi-primary@5 to match the value of LPASS_DP_RX define

> + reg = <LPASS_DP_RX>;
> + };
> };