Re: [PATCH] bus: ti-sysc: Fix gpt12 system timer issue with reserved status

From: Tony Lindgren
Date: Wed Aug 11 2021 - 02:12:25 EST


* Tony Lindgren <tony@xxxxxxxxxxx> [210810 12:52]:
> * Pavel Machek <pavel@xxxxxxx> [210810 12:40]:
> > What is going on here? First, we silently ignore errors other than
> > EBUSY. Second, sysc_check_active_timer() can't return -EBUSY: it
> > returns either 0 or -ENXIO. (I checked 5.10-stable, mainline and
> > -next-20210806).
>
> Thanks for spotting it, looks like there's now a conflict with commit
> 65fb73676112 ("bus: ti-sysc: suppress err msg for timers used as
> clockevent/source"). It seems we should also check for -ENXIO here
> too. And yeah it makes sens to return on other errors for sure.

FYI, fix posted at [0] below.

Regards,

Tony

[0] https://lore.kernel.org/linux-omap/20210811061053.32081-1-tony@xxxxxxxxxxx/T/#u