Re: [PATCH 09/11] usb: xhci-mtk: check boundary before check tt

From: Chunfeng Yun (云春峰)
Date: Wed Aug 11 2021 - 04:18:24 EST

Next message: Slark Xiao: "[PATCH] Fix WWAN device disabled issue after S3 deep When WWAN device wake from S3 deep, under thinkpad platform,it would be disabled. This disable status could be checked by command 'nmcli r wwan' or 'rfkill list'. Issue analysis as below: 1. When host resume from S3 deep, thinkpad_acpi driver would call hotkey_resume() function. Finnaly, it will use wan_get_status to check the current status of WWAN device. During this resume progress, wan_get_status would always return off even WWAN boot up completely. 2. If wan_get_status() return off, rfkill_set_sw_state() would set WWAN's status as disabled. 3. This may be a fault of LENOVO BIOS. 4. Workaround is add a WWAN device check before rfkill_set_sw_state(). If it's a Foxconn WWAN device, then we will ignore to do a status update."
Previous message: Jason Wang: "[RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO"
In reply to: Ikjoon Jang: "Re: [PATCH 09/11] usb: xhci-mtk: check boundary before check tt"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mon, 2021-08-09 at 15:32 +0800, Ikjoon Jang wrote:
> Hi Chunfeng,
>
> On Fri, Jul 30, 2021 at 4:50 PM Chunfeng Yun <
> chunfeng.yun@xxxxxxxxxxxx> wrote:
> >
> > check_sch_tt() will access fs_bus_bw[] array, check boundary
> > firstly to avoid out-of-bounds issue.
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx>
> > ---
> > drivers/usb/host/xhci-mtk-sch.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/usb/host/xhci-mtk-sch.c
> > b/drivers/usb/host/xhci-mtk-sch.c
> > index 10c0f0f6461f..c2f13d69c607 100644
> > --- a/drivers/usb/host/xhci-mtk-sch.c
> > +++ b/drivers/usb/host/xhci-mtk-sch.c
> > @@ -600,13 +600,14 @@ static int check_sch_bw(struct
> > mu3h_sch_bw_info *sch_bw,
> > * and find a microframe where its worst bandwidth is
> > minimum.
> > */
> > for (offset = 0; offset < sch_ep->esit; offset++) {
> > - ret = check_sch_tt(sch_ep, offset);
> > - if (ret)
> > - continue;
> >
> > if ((offset + sch_ep->num_budget_microframes) >
> > esit_boundary)
> > break;
>
> Instead of dropping it,
> I'm wondering if it should be checked against (offset & 63) == 0 when
> it's 64?
No, sch_ep->esit already ensure it, it's <= 64, see get_esit()

>
> >
> > + ret = check_sch_tt(sch_ep, offset);
> > + if (ret)
> > + continue;
> > +
> > worst_bw = get_max_bw(sch_bw, sch_ep, offset);
> > if (worst_bw > bw_boundary)
> > continue;
> > --
> > 2.18.0
> >