Re: [PATCH] ARM: NOMMU: Return true/false (not 1/0) from bool functions

[Vladimir Murzin]

On 8/11/21 9:20 AM, Huilong Deng wrote:
> ./arch/arm/mm/nommu.c:59:8-9: WARNING: return of 0/1 in function
> 'security_extensions_enabled' with return type bool
> 
> Signed-off-by: Huilong Deng <denghuilong@xxxxxxxxxx>
> ---
>  arch/arm/mm/nommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mm/nommu.c b/arch/arm/mm/nommu.c
> index 2658f52903da..7256ac159acb 100644
> --- a/arch/arm/mm/nommu.c
> +++ b/arch/arm/mm/nommu.c
> @@ -56,7 +56,7 @@ static inline bool security_extensions_enabled(void)
>  	if ((read_cpuid_id() & 0x000f0000) == 0x000f0000)
>  		return cpuid_feature_extract(CPUID_EXT_PFR1, 4) ||
>  			cpuid_feature_extract(CPUID_EXT_PFR1, 20);
> -	return 0;
> +	return false;
>  }
>  
>  unsigned long setup_vectors_base(void)
> 

Reviewed-by: Vladimir Murzin <vladimir.murzin@xxxxxxx>

Please, submit it into RMK's Patch system [1]

[1] https://www.armlinux.org.uk/developer/patches/

Cheers
Vladimir