Re: [PATCH net-next] net: dsa: mt7530: fix VLAN traffic leaks again
From: Vladimir Oltean
Date: Wed Aug 11 2021 - 06:01:30 EST
On Wed, Aug 11, 2021 at 05:50:43PM +0800, DENG Qingfang wrote:
> When a port leaves a VLAN-aware bridge, the current code does not clear
> other ports' matrix field bit. If the bridge is later set to VLAN-unaware
> mode, traffic in the bridge may leak to that port.
>
> Remove the VLAN filtering check in mt7530_port_bridge_leave.
>
> Fixes: 474a2ddaa192 ("net: dsa: mt7530: fix VLAN traffic leaks")
> Fixes: 83163f7dca56 ("net: dsa: mediatek: add VLAN support for MT7530")
> Signed-off-by: DENG Qingfang <dqfext@xxxxxxxxx>
> ---
That hunk looked indeed very strange when I went over it with commit
'net: dsa: remove the "dsa_to_port in a loop" antipattern from drivers',
so I'm happy to see it go away.
Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx>