Re: [PATCH] ASoC: stm32: spdifrx: Delete unnecessary check in the probe function
From: Mark Brown
Date: Wed Aug 11 2021 - 07:59:07 EST
On Wed, Aug 11, 2021 at 07:55:23PM +0800, Tang Bin wrote:
> The function stm32_spdifrx_parse_of() is only called by the function
> stm32_spdifrx_probe(), and the probe function is only called with
> an openfirmware platform device. Therefore there is no need to check
> the device_node in probe function.
What is the benefit of not doing the check? It seems like reasonable
defensive programming.
Attachment:
signature.asc
Description: PGP signature