Re: [v6 2/2] arm64: dts: mediatek: Correct UART0 bus clock of MT8192

From: Chun-Jie Chen
Date: Wed Aug 11 2021 - 08:12:46 EST


On Thu, 2021-08-05 at 17:44 +0200, Matthias Brugger wrote:
>
> On 30/07/2021 04:43, Chun-Jie Chen wrote:
> > On Wed, 2021-07-28 at 14:14 +0800, Ikjoon Jang wrote:
> > > Hi,
> > >
> > > On Tue, Jul 27, 2021 at 10:43 AM Chun-Jie Chen
> > > <chun-jie.chen@xxxxxxxxxxxx> wrote:
> > > >
> > > > infra_uart0 clock is the real one what uart0 uses as bus clock.
> > > >
> > > > Signed-off-by: Weiyi Lu <weiyi.lu@xxxxxxxxxxxx>
> > > > Signed-off-by: Chun-Jie Chen <chun-jie.chen@xxxxxxxxxxxx>
> > > > ---
> > > > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > > > b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > > > index c7c7d4e017ae..9810f1d441da 100644
> > > > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > > > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > > > @@ -327,7 +327,7 @@
> > > > "mediatek,mt6577-uart";
> > > > reg = <0 0x11002000 0 0x1000>;
> > > > interrupts = <GIC_SPI 109
> > > > IRQ_TYPE_LEVEL_HIGH 0>;
> > > > - clocks = <&clk26m>, <&clk26m>;
> > > > + clocks = <&clk26m>, <&infracfg
> > > > CLK_INFRA_UART0>;
> > > > clock-names = "baud", "bus";
> > > > status = "disabled";
> > > > };
> > >
> > > There're many other nodes still having only clk26m. Will you
> > > update
> > > them too?
> > >
> >
> > Others will be updated by IP owner.
> >
>
> As it seems we will have some time before this can be merged, could
> you help
> work with the other IP owners to get one big patch that updates all
> clocks?
>
> Thanks a lot,
> Matthias
>

Ok, I will update all clock setting (uart/nor_flash/i2c/spi) in
mt8192.dtsi at the latest kernel version. Did you suggest to merge all
to one patch or separate to different patches but put in same
series?

Best Regards,
Chun-Jie

> > Best Regards,
> > Chun-Jie
> >
> > > > --
> > > > 2.18.0
> > > > _______________________________________________
> > > > Linux-mediatek mailing list
> > > > Linux-mediatek@xxxxxxxxxxxxxxxxxxx
> > > >
> >
> >
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!1bIz6X2EiFbigCImzQmbqtezIFfl1LRBuPOYTqBdl5wfx8b-zp0zQP68R7RhaIcAAXXF$
> > > >