Re: [RFC PATCH v2 1/1] misc: add sloppy logic analyzer using polling

From: Andy Shevchenko
Date: Wed Aug 11 2021 - 08:40:24 EST


On Tue, Aug 10, 2021 at 10:32:23AM +0200, Wolfram Sang wrote:
> Hi Andy,
>
> > Nope. Below is the compile-tested one:
>
> Well, then let's add this incrementally once it has actually been
> tested.

I have no strong opinion here, I just considered that ACPI code is good to have
as well.

> > > I don't understand the first sentence. And we still need it to clean up?
> >
> > If you know the name of the folder, you may look up it, no need to keep a
> > variable for that.
>
> I need the dentry twice, subdirs are also created in there. Of course, I
> could look it up twice, but why the computation? The variable seems
> simpler to me, despite it being static. Or is it a debugfs rule to not
> save dentries?

I think the best person to ask is Greg :-)

--
With Best Regards,
Andy Shevchenko