Re: [PATCH for-next] RDMA/core/sa_query: Remove unused function

[Haakon Bugge]

> On 11 Aug 2021, at 14:33, Leon Romanovsky <leon@xxxxxxxxxx> wrote:
> 
> On Wed, Aug 11, 2021 at 02:27:11PM +0200, Håkon Bugge wrote:
>> ib_sa_service_rec_query() was introduced in kernel v2.6.13 by commit
>> cbae32c56314 ("[PATCH] IB: Add Service Record support to SA client")
>> in 2005. It was not used then and have never been used since.
>> 
>> Removing it.
>> 
>> Signed-off-by: Håkon Bugge <haakon.bugge@xxxxxxxxxx>
>> ---
>> drivers/infiniband/core/sa_query.c | 101 -------------------------------------
>> include/rdma/ib_sa.h               |  10 ----
>> 2 files changed, 111 deletions(-)
> 
> You shouldn't stop there and remove ib_sa_service_rec_callback,
> ib_sa_service_rec_release, ib_sa_service_query and probably
> ib_sa_service_rec.

I checked all functions called from ib_sa_service_rec_query() were used elsewhere, and they were indeed. But overlooked the function assignments :-) Thanks for pointing it out. A v2 will follow.


Thxs, Håkon