Re: [PATCH v2 2/2] wwan: core: Unshadow error code returned by ida_alloc_range))

[Andy Shevchenko]

On Fri, Aug 06, 2021 at 11:35:04PM +0300, Sergey Ryazanov wrote:
> On Fri, Aug 6, 2021 at 5:20 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Fri, Aug 6, 2021 at 5:14 PM Sergey Ryazanov <ryazanov.s.a@xxxxxxxxx> wrote:
> >> On Fri, Aug 6, 2021 at 12:00 PM Andy Shevchenko
> >> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >>> ida_alloc_range)) may return other than -ENOMEM error code.
> >>> Unshadow it in the wwan_create_port().
> >>>
> >>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> >>
> >> A small nitpick, looks like "ida_alloc_range))" in the description is
> >> a typo and should be "ida_alloc_range()". Besides this:
> >
> > Shall I resend?
> 
> Yes, please. And specify the target tree in the subject, please. See
> patchwork warning [1, 2]. The first patch is a clear bug fix, so it
> should be targeted to the 'net' tree, while the second patch despite
> its usefulness could not be considered a bug fix, so it should be
> targeted to the 'net-next' tree. Subjects could be like this:
> 
> [PATCHv3 net 1/2] wwan: core: Avoid returning NULL from wwan_create_dev()
> [PATCHv3 net-next 2/2] wwan: core: Unshadow error code returned by
> ida_alloc_range()
> 
> Or since the second patch is not depends on the first one and patches
> target different trees, patches could be submitted independently:
> 
> [PATCHv3 net] wwan: core: Avoid returning NULL from wwan_create_dev()
> [PATCHv3 net-next] wwan: core: Unshadow error code returned by ida_alloc_range()

Split and sent separately, thanks!

> 1. https://patchwork.kernel.org/project/netdevbpf/patch/20210806085413.61536-1-andriy.shevchenko@xxxxxxxxxxxxxxx/
> 2. https://patchwork.kernel.org/project/netdevbpf/patch/20210806085413.61536-2-andriy.shevchenko@xxxxxxxxxxxxxxx/

-- 
With Best Regards,
Andy Shevchenko