Re: [PATCH 1/2] f2fs: fix potential memory leaks in create_discard_cmd_control

From: Chao Yu
Date: Wed Aug 11 2021 - 09:36:58 EST


On 2021/8/11 21:18, Yangtao Li wrote:
Release f2fs_issue_discard every time it is destroyed,
otherwise it will cause memory leaks when remounting.

I didn't get the problem here, could you please explain a bit more about
details?

Thanks,


Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>
---
fs/f2fs/segment.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index afe20c5c3c08..363779a4402d 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1741,6 +1741,7 @@ void f2fs_stop_discard_thread(struct f2fs_sb_info *sbi)
dcc->f2fs_issue_discard = NULL;
kthread_stop(discard_thread);
+ put_task_struct(discard_thread);
}
}
@@ -2168,6 +2169,7 @@ static int create_discard_cmd_control(struct f2fs_sb_info *sbi)
SM_I(sbi)->dcc_info = NULL;
return err;
}
+ get_task_struct(dcc->f2fs_issue_discard);
return err;
}