Re: [PATCH 03/18] ARC: mm: move mmu/cache externs out to setup.h

[Vineet Gupta]

Hi Mike,

On 8/10/21 10:10 PM, Mike Rapoport wrote:
> Hi Vineet,
>
> On Tue, Aug 10, 2021 at 05:42:43PM -0700, Vineet Gupta wrote:
> > Signed-off-by: Vineet Gupta <vgupta@xxxxxxxxxx>
> Hmm, this one seems odd. Try https://www.kernel.com/ ;-)

Oops, last minute switch to my kernel.org address - this update was not 
atomic ;-)

> > Signed-off-by: Vineet Gupta <vgupta@xxxxxxxxxx>
> > ---
> >   arch/arc/include/asm/cache.h |  4 ----
> >   arch/arc/include/asm/mmu.h   |  4 ----
> >   arch/arc/include/asm/setup.h | 12 ++++++++++--
> A sentence about why these move would have been nice.

Sure
---->
"Don't pollute mmu.h and cache.h with some of ARC internal bootlog/setup 
related functions.
move them aside to setup.h"

Thx for taking the time to review !

-Vineet